PeterCxy/OpenEUICC
16
24
Fork 20
Code Issues 7 Pull requests Projects Releases 8 Wiki Activity Actions

feat: profile rename more toast hints #111

Closed
septs wants to merge 15 commits from septs:profile-rename-strong-checking into master
pull from: septs:profile-rename-strong-checking
merge into: PeterCxy:master
Conversation 1 Commits 15 Files changed 4 +119 -27
septs commented 2024-12-12 10:51:51 +01:00
Contributor
Copy link
No description provided.
septs added 1 commit 2024-12-12 10:51:55 +01:00
septs added 1 commit 2024-12-12 12:31:54 +01:00
septs added 1 commit 2024-12-12 12:57:01 +01:00
septs added 1 commit 2024-12-12 13:11:36 +01:00
septs added 1 commit 2024-12-12 13:32:04 +01:00
septs added 1 commit 2024-12-13 03:54:31 +01:00
septs changed title from feat: profile rename strong checking to feat: profile rename more toast hints 2024-12-13 03:54:35 +01:00
septs added 1 commit 2024-12-13 04:23:12 +01:00
PeterCxy commented 2024-12-13 04:30:34 +01:00
Owner
Copy link

Validating against GSMA standard isn't the concern of UI. This should be custom exceptions thrown from LocalProfileAssistantImpl in lpac-jni and exposed through UI toasts instead.

Validating against GSMA standard isn't the concern of UI. This should be custom exceptions thrown from LocalProfileAssistantImpl in `lpac-jni` and exposed through UI toasts instead.
septs added 1 commit 2024-12-13 04:41:39 +01:00
septs added 1 commit 2024-12-13 04:45:06 +01:00
PeterCxy reviewed 2024-12-13 04:47:48 +01:00
app-common/src/main/res/values/strings.xml Outdated
@ -29,2 +29,4 @@
<string name="toast_profile_enable_failed">Cannot switch to new eSIM profile.</string>
<string name="toast_profile_name_changed">The profile name will be updated from \'%s\' to \'%s\'</string>
<string name="toast_profile_name_not_changed">Nickname has not changed</string>
PeterCxy commented 2024-12-13 04:47:47 +01:00
Owner
Copy link

is unchanged

is unchanged
PeterCxy reviewed 2024-12-13 04:48:25 +01:00
app-common/src/main/res/values/strings.xml Outdated
@ -31,1 +31,4 @@
<string name="toast_profile_name_changed">The profile name will be updated from \'%s\' to \'%s\'</string>
<string name="toast_profile_name_not_changed">Nickname has not changed</string>
<string name="toast_profile_name_too_long">Nickname cannot be longer than 64 characters</string>
<string name="toast_profile_name_encode_failed">The input string could not be encoded</string>
PeterCxy commented 2024-12-13 04:48:24 +01:00
Owner
Copy link

could not be encoded as UTF-8

could not be encoded as UTF-8
PeterCxy reviewed 2024-12-13 04:49:19 +01:00
app-common/src/main/res/values/strings.xml Outdated
@ -31,1 +32,4 @@
<string name="toast_profile_name_not_changed">Nickname has not changed</string>
<string name="toast_profile_name_too_long">Nickname cannot be longer than 64 characters</string>
<string name="toast_profile_name_encode_failed">The input string could not be encoded</string>
<string name="toast_profile_name_restore_defaults">This profile name will be restored to the default</string>
PeterCxy commented 2024-12-13 04:49:18 +01:00
Owner
Copy link

delete "the"

delete "the"
septs added 2 commits 2024-12-13 06:14:46 +01:00
septs added 1 commit 2024-12-13 06:17:12 +01:00
septs added 1 commit 2024-12-13 06:38:14 +01:00
septs added 1 commit 2024-12-13 07:16:03 +01:00
septs added 1 commit 2024-12-13 07:19:50 +01:00
septs closed this pull request 2024-12-13 07:56:34 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: PeterCxy/OpenEUICC#111
No description provided.
Delete branch "septs:profile-rename-strong-checking"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?