PeterCxy/OpenEUICC
16
24
Fork 20
Code Issues 7 Pull requests Projects Releases 8 Wiki Activity Actions

fix: manually state restore #132

Closed
septs wants to merge 1 commit from septs:manually-state-restore into master
pull from: septs:manually-state-restore
merge into: PeterCxy:master
Conversation 0 Commits 1 Files changed 2 +48 -37
septs commented 2024-12-18 18:00:57 +01:00
Contributor
Copy link

resolves #131

resolves #131
septs changed title from feat: manually state restore to fix: manually state restore 2024-12-18 18:02:22 +01:00
septs force-pushed manually-state-restore from 2374ad6fb4 to 910801c973 2024-12-18 18:36:41 +01:00 Compare
septs force-pushed manually-state-restore from 910801c973 to 4f6e96ccf9 2024-12-18 18:38:13 +01:00 Compare
PeterCxy reviewed 2024-12-18 23:56:56 +01:00
app-common/src/main/java/im/angry/openeuicc/ui/wizard/DownloadWizardDetailsFragment.kt
@ -68,0 +63,4 @@
override fun onSaveInstanceState(outState: Bundle) {
super.onSaveInstanceState(outState)
outState.putString(FIELD_SMDP, smdp.text.toString())
PeterCxy commented 2024-12-18 23:56:56 +01:00
Owner
Copy link

DownloadWizardActivity already has state. We should just store it there in this function.

That would remove the need for onViewStateRestored as well.

`DownloadWizardActivity` already has state. We should just store it there in this function. That would remove the need for `onViewStateRestored` as well.
PeterCxy closed this pull request 2024-12-19 00:03:08 +01:00
septs deleted branch manually-state-restore 2024-12-19 01:38:04 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: PeterCxy/OpenEUICC#132
No description provided.
Delete branch "septs:manually-state-restore"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?