PeterCxy/OpenEUICC
16
24
Fork 20
Code Issues 7 Pull requests Projects Releases 8 Wiki Activity Actions

refactor: download wizard details form #163

Closed
septs wants to merge 20 commits from septs:stricted-imei into master
pull from: septs:stricted-imei
merge into: PeterCxy:master
Conversation 1 Commits 20 Files changed 5 +147 -30
septs commented 2025-03-06 22:12:00 +01:00
Contributor
Copy link

resolves #165

resolves #165
septs added 1 commit 2025-03-06 22:12:02 +01:00
septs force-pushed stricted-imei from 53cc032ca2 to 48b7f0bfef 2025-03-06 22:19:08 +01:00 Compare
septs changed title from feat: stricted imei checking to WIP: feat: stricted imei checking 2025-03-06 23:22:01 +01:00
septs force-pushed stricted-imei from 48b7f0bfef to 598c45bd60 2025-03-06 23:33:25 +01:00 Compare
septs force-pushed stricted-imei from 598c45bd60 to 81d1fb2b70 2025-03-06 23:58:16 +01:00 Compare
septs force-pushed stricted-imei from 81d1fb2b70 to 0b80eb1262 2025-03-07 00:04:46 +01:00 Compare
septs force-pushed stricted-imei from 0b80eb1262 to 1743e20fdc 2025-03-07 00:07:51 +01:00 Compare
septs added 1 commit 2025-03-07 01:12:40 +01:00
septs added 1 commit 2025-03-07 01:20:03 +01:00
septs changed title from WIP: feat: stricted imei checking to WIP: feat: stricted download wizard details checking 2025-03-07 03:54:17 +01:00
septs added 1 commit 2025-03-07 04:07:26 +01:00
septs added 1 commit 2025-03-07 04:09:13 +01:00
septs added 1 commit 2025-03-07 04:21:56 +01:00
septs added 1 commit 2025-03-07 04:36:34 +01:00
septs changed title from WIP: feat: stricted download wizard details checking to feat: stricted download wizard details checking 2025-03-07 06:09:29 +01:00
septs changed title from feat: stricted download wizard details checking to feat: stricted download wizard details form checking 2025-03-07 06:10:06 +01:00
septs added 1 commit 2025-03-07 06:22:49 +01:00
septs added 1 commit 2025-03-07 08:25:11 +01:00
septs changed title from feat: stricted download wizard details form checking to refactor: download wizard details form 2025-03-07 08:25:23 +01:00
septs added 1 commit 2025-03-07 08:26:14 +01:00
septs added 1 commit 2025-03-07 10:12:05 +01:00
septs added 1 commit 2025-03-07 12:53:27 +01:00
septs added 1 commit 2025-03-07 12:57:44 +01:00
septs added 1 commit 2025-03-08 01:32:22 +01:00
septs added 1 commit 2025-03-08 01:49:09 +01:00
septs added 1 commit 2025-03-08 02:10:10 +01:00
septs added 1 commit 2025-03-08 04:32:25 +01:00
septs added 1 commit 2025-03-08 05:05:55 +01:00
septs added 1 commit 2025-03-08 05:21:59 +01:00
septs added 1 commit 2025-03-08 07:42:31 +01:00
PeterCxy commented 2025-03-08 17:01:18 +01:00
Owner
Copy link

I don't see a point validating input manually especially since (1) FQDN validation is handled well by a regex; and (2) any error here results in failure whose reason we now display explicitly. Assuming confirmation code is "mostly" numbers also seems weird to me and I don't see why we have to add a button to switch between number / letters.

I'm also not a fan of how the validation is implemented here. If anything they should live in utils, not as part of UI code. And it seems to me that doing this type of validation manually is error prone and I'd rather just leave it to the servers.

I don't see a point validating input manually especially since (1) FQDN validation is handled well by a regex; and (2) any error here results in failure whose reason we now display explicitly. Assuming confirmation code is "mostly" numbers also seems weird to me and I don't see why we have to add a button to switch between number / letters. I'm also not a fan of how the validation is implemented here. If anything they should live in utils, not as part of UI code. And it seems to me that doing this type of validation manually is error prone and I'd rather just leave it to the servers.
PeterCxy closed this pull request 2025-03-08 17:01:19 +01:00
septs deleted branch stricted-imei 2025-03-08 17:50:15 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: PeterCxy/OpenEUICC#163
No description provided.
Delete branch "septs:stricted-imei"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?