PeterCxy/OpenEUICC
16
24
Fork 20
Code Issues 7 Pull requests Projects Releases 8 Wiki Activity Actions

fix: improve lpa string parsing #181

Merged
PeterCxy merged 3 commits from septs/OpenEUICC:improve-lpa-string-parsing into master 2025-04-01 03:19:22 +02:00
Conversation 2 Commits 3 Files changed 1 +8 -8
septs commented 2025-03-16 07:02:51 +01:00
Contributor
Copy link
No description provided.
septs added 1 commit 2025-03-16 07:02:51 +01:00
septs force-pushed improve-lpa-string-parsing from 15b9a90db0 to bb5417d37f 2025-03-16 09:15:26 +01:00 Compare
PeterCxy commented 2025-03-17 00:03:06 +01:00
Owner
Copy link

What does this fix? check's exceptions are not supposed to be caught. They are intended to function like asserts

What does this fix? `check`'s exceptions are not supposed to be caught. They are intended to function like `assert`s
septs changed title from chore: improve lpa string parsing to fix: improve lpa string parsing 2025-03-17 02:45:54 +01:00
PeterCxy commented 2025-03-17 23:20:40 +01:00
Owner
Copy link

Please do not use check{,NotNull}() for argument contracts. Use require{,NotNull}() for them and keep the IllegalArgumentException

Please do _not_ use `check{,NotNull}()` for argument contracts. Use `require{,NotNull}()` for them and keep the `IllegalArgumentException`
septs added 1 commit 2025-03-20 09:24:30 +01:00
septs added 1 commit 2025-03-20 09:32:11 +01:00
PeterCxy merged commit 00ddf09287 into master 2025-04-01 03:19:22 +02:00
PeterCxy deleted branch improve-lpa-string-parsing 2025-04-01 03:19:22 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: PeterCxy/OpenEUICC#181
No description provided.
Delete branch "septs/OpenEUICC:improve-lpa-string-parsing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?