PeterCxy/OpenEUICC
17
31
Fork 22
Code Issues 6 Pull requests 2 Projects Releases 8 Wiki Activity Actions

feat: improve notification permission request #210

Closed
septs wants to merge 4 commits from septs:notification-request into master
pull from: septs:notification-request
merge into: PeterCxy:master
Conversation 2 Commits 4 Files changed 2 +22 -9
septs commented 2025-07-28 15:44:54 +02:00
Contributor
Copy link

If the ContextCompat.checkSelfPermission() method returns PERMISSION_DENIED, call shouldShowRequestPermissionRationale(). If this method returns true, show an educational UI to the user. In this UI, describe why the feature that the user wants to enable needs a particular permission.

from https://developer.android.com/training/permissions/requesting

> If the ContextCompat.checkSelfPermission() method returns PERMISSION_DENIED, call shouldShowRequestPermissionRationale(). If this method returns true, show an educational UI to the user. In this UI, describe why the feature that the user wants to enable needs a particular permission. from https://developer.android.com/training/permissions/requesting
septs added 1 commit 2025-07-28 15:44:54 +02:00
septs force-pushed notification-request from aa8e3f5e53 to 80afe37050 2025-07-29 04:53:52 +02:00 Compare
septs changed title from chore: simplify notification permission request to feat: improve notification permission request 2025-07-29 04:54:02 +02:00
septs commented 2025-07-29 04:55:35 +02:00
Author
Contributor
Copy link

Screenshot_20250729-105431

![Screenshot_20250729-105431](/attachments/4bc15afc-b297-4e2a-b38d-ad734e310d9e)
Screenshot_20250729-105431.png
86 KiB
septs added 1 commit 2025-07-29 06:55:20 +02:00
septs added 1 commit 2025-07-29 08:35:57 +02:00
septs added 1 commit 2025-07-29 09:53:51 +02:00
PeterCxy commented 2025-08-10 22:08:06 +02:00
Owner
Copy link

This really shouldn't be a concern. Even if we don't get notification permissions we still get to stay in foreground as long as we post the foreground notification.

This really shouldn't be a concern. Even if we don't get notification permissions we still get to stay in foreground as long as we post the foreground notification.
septs closed this pull request 2025-08-11 07:13:39 +02:00
septs deleted branch notification-request 2025-08-11 07:13:45 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: PeterCxy/OpenEUICC#210
No description provided.
Delete branch "septs:notification-request"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?