PeterCxy/OpenEUICC
16
30
Fork 21
Code Issues 7 Pull requests 3 Projects Releases 8 Wiki Activity Actions

feat: improve notification permission request #210

Open
septs wants to merge 4 commits from septs/OpenEUICC:notification-request into master
pull from: septs/OpenEUICC:notification-request
merge into: PeterCxy:master
Conversation 1 Commits 4 Files changed 2 +22 -9
septs commented 2025-07-28 15:44:54 +02:00
Contributor
Copy link

If the ContextCompat.checkSelfPermission() method returns PERMISSION_DENIED, call shouldShowRequestPermissionRationale(). If this method returns true, show an educational UI to the user. In this UI, describe why the feature that the user wants to enable needs a particular permission.

from https://developer.android.com/training/permissions/requesting

> If the ContextCompat.checkSelfPermission() method returns PERMISSION_DENIED, call shouldShowRequestPermissionRationale(). If this method returns true, show an educational UI to the user. In this UI, describe why the feature that the user wants to enable needs a particular permission. from https://developer.android.com/training/permissions/requesting
septs added 1 commit 2025-07-28 15:44:54 +02:00
septs force-pushed notification-request from aa8e3f5e53 to 80afe37050 2025-07-29 04:53:52 +02:00 Compare
septs changed title from chore: simplify notification permission request to feat: improve notification permission request 2025-07-29 04:54:02 +02:00
septs commented 2025-07-29 04:55:35 +02:00
Author
Contributor
Copy link

Screenshot_20250729-105431

![Screenshot_20250729-105431](/attachments/4bc15afc-b297-4e2a-b38d-ad734e310d9e)
Screenshot_20250729-105431.png
86 KiB
septs added 1 commit 2025-07-29 06:55:20 +02:00
septs added 1 commit 2025-07-29 08:35:57 +02:00
septs added 1 commit 2025-07-29 09:53:51 +02:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u notification-request:septs-notification-request
git checkout septs-notification-request

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master
git merge --no-ff septs-notification-request
git checkout septs-notification-request
git rebase master
git checkout master
git merge --ff-only septs-notification-request
git checkout septs-notification-request
git rebase master
git checkout master
git merge --no-ff septs-notification-request
git checkout master
git merge --squash septs-notification-request
git checkout master
git merge --ff-only septs-notification-request
git checkout master
git merge septs-notification-request
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: PeterCxy/OpenEUICC#210
No description provided.
Delete branch "septs/OpenEUICC:notification-request"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?