PeterCxy/irqbalance
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #229 from liuchao173/patch-2

Browse source 
irqbalance-ui: skip ',' in parse_setup to avoid coredump
This commit is contained in:
Neil Horman 2022-07-18 08:17:55 -04:00 committed by GitHub
parent 56a9a0ffbc c8d1fff0f1
commit 5cabefe575
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ui/irqbalance-ui.c
View file

@ -142,7 +142,7 @@ try_again:
void parse_setup(char *setup_data) void parse_setup(char *setup_data)
{ {
char *token, *ptr; char *token, *ptr;
int i,j; int i,j, cpu = 0;
char *copy; char *copy;
irq_t *new_irq = NULL; irq_t *new_irq = NULL;
if((setup_data == NULL) || (strlen(setup_data) == 0)) return; if((setup_data == NULL) || (strlen(setup_data) == 0)) return;
@ -179,14 +179,17 @@ void parse_setup(char *setup_data)
if(strncmp(token, "BANNED", strlen("BANNED"))) goto out; if(strncmp(token, "BANNED", strlen("BANNED"))) goto out;
token = strtok_r(NULL, " ", &ptr); token = strtok_r(NULL, " ", &ptr);
for(i = strlen(token) - 1; i >= 0; i--) { for(i = strlen(token) - 1; i >= 0; i--) {
if (token[i] == ',')
continue;
char *map = hex_to_bitmap(token[i]); char *map = hex_to_bitmap(token[i]);
for(j = 3; j >= 0; j--) { for(j = 3; j >= 0; j--) {
if(map[j] == '1') { if(map[j] == '1') {
uint64_t *banned_cpu = malloc(sizeof(uint64_t)); uint64_t *banned_cpu = malloc(sizeof(uint64_t));
*banned_cpu = (4 * (strlen(token) - (i + 1)) + (4 - (j + 1))); *banned_cpu = cpu;
setup.banned_cpus = g_list_append(setup.banned_cpus, setup.banned_cpus = g_list_append(setup.banned_cpus,
banned_cpu); banned_cpu);
} }
cpu++;
} }
free(map); free(map);