There's no point having these two vals just to get() = requireArguments()...
. Using by lazy
might be more appropriate if that's the aim.
.also { show() }
removes the need for !!
Validating against GSMA standard isn't the concern of UI. This should be custom exceptions thrown from LocalProfileAssistantImpl in lpac-jni
and exposed through UI toasts instead.
This is not sustainable. We are going to fix this with a DI strings provider.
Intent.ACTION_SEND
also accepts Intent.EXTRA_TEXT
directly. Our logs should fit nicely inside that extra field. There is 0 need for a FileProvider
implementation.
FileProvider is not needed if you simply write the file out to sdcard like we normally do.
This does not really simplify the code at all compared to using ClipboardManager
API directly, most evident by the need for a callback still.
Again, do not add abstraction for the sake of…