Peter Cai PeterCxy
  • 猫である。

  • Joined on 2021-08-16
PeterCxy commented on pull request PeterCxy/OpenEUICC#110 2024-12-13 04:34:59 +01:00
feat: if profile delete confirm text is mismatched then show toast

unmatched -> mismatched

PeterCxy commented on pull request PeterCxy/OpenEUICC#110 2024-12-13 04:34:55 +01:00
feat: if profile delete confirm text is mismatched then show toast

There's no point having these two vals just to get() = requireArguments().... Using by lazy might be more appropriate if that's the aim.

PeterCxy commented on pull request PeterCxy/OpenEUICC#110 2024-12-13 04:34:51 +01:00
feat: if profile delete confirm text is mismatched then show toast

.also { show() } removes the need for !!

PeterCxy commented on pull request PeterCxy/OpenEUICC#111 2024-12-13 04:30:36 +01:00
feat: profile rename more toast hints

Validating against GSMA standard isn't the concern of UI. This should be custom exceptions thrown from LocalProfileAssistantImpl in lpac-jni and exposed through UI toasts instead.

PeterCxy closed pull request PeterCxy/OpenEUICC#109 2024-12-13 04:27:06 +01:00
fix: override unpriv channel name in all languages
PeterCxy commented on pull request PeterCxy/OpenEUICC#109 2024-12-13 04:26:54 +01:00
fix: override unpriv channel name in all languages

This is not sustainable. We are going to fix this with a DI strings provider.

PeterCxy commented on pull request PeterCxy/OpenEUICC#105 2024-12-12 02:13:30 +01:00
feat: share logs as file

Intent.ACTION_SEND also accepts Intent.EXTRA_TEXT directly. Our logs should fit nicely inside that extra field. There is 0 need for a FileProvider implementation.

PeterCxy commented on pull request PeterCxy/OpenEUICC#105 2024-12-12 02:11:09 +01:00
feat: share logs as file

FileProvider is not needed if you simply write the file out to sdcard like we normally do.

PeterCxy merged pull request PeterCxy/OpenEUICC#103 2024-12-12 02:09:17 +01:00
fix: euiccinfo activity channel title
PeterCxy pushed to master at PeterCxy/OpenEUICC 2024-12-12 02:09:15 +01:00
6d962a12b5 fix: euiccinfo activity channel title (#103)
PeterCxy pushed to fix-euicc-info-channel-title at septs/OpenEUICC 2024-12-12 02:08:06 +01:00
8c8e0befd8 Merge branch 'master' into fix-euicc-info-channel-title
8f9c7137f6 feat: show incorrect lpa string alert dialog (#101)
Compare 2 commits »
PeterCxy closed pull request PeterCxy/OpenEUICC#104 2024-12-12 02:06:52 +01:00
refactor: extract clipboard setter as utils
PeterCxy commented on pull request PeterCxy/OpenEUICC#104 2024-12-12 02:06:31 +01:00
refactor: extract clipboard setter as utils

This does not really simplify the code at all compared to using ClipboardManager API directly, most evident by the need for a callback still.

Again, do not add abstraction for the sake of…

PeterCxy suggested changes for PeterCxy/OpenEUICC#102 2024-12-12 02:04:33 +01:00
refactor: certificate issuer detecting
PeterCxy commented on pull request PeterCxy/OpenEUICC#102 2024-12-12 02:04:28 +01:00
refactor: certificate issuer detecting

what does mp mean?

PeterCxy commented on pull request PeterCxy/OpenEUICC#102 2024-12-12 02:04:24 +01:00
refactor: certificate issuer detecting

These should not be untranslatable

PeterCxy commented on pull request PeterCxy/OpenEUICC#102 2024-12-12 02:04:21 +01:00
refactor: certificate issuer detecting

Unknown eSIM CA

PeterCxy pushed to master at PeterCxy/OpenEUICC 2024-12-12 01:59:25 +01:00
8f9c7137f6 feat: show incorrect lpa string alert dialog (#101)
PeterCxy merged pull request PeterCxy/OpenEUICC#101 2024-12-12 01:59:25 +01:00
feat: show incorrect lpa string alert dialog