mirror of
https://codeberg.org/forgejo/forgejo
synced 2025-10-19 11:40:53 +02:00
debf12f6c5
It must return on error instead, and log a stack trace for forensic analysis. Refs https://codeberg.org/forgejo/forgejo/issues/9472 ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] I do not want this change to show in the release notes. - [ ] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9478 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Co-authored-by: Earl Warren <contact@earl-warren.org> Co-committed-by: Earl Warren <contact@earl-warren.org>
28 lines
562 B
Go
28 lines
562 B
Go
// Copyright 2025 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
package donotpanic
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"forgejo.org/modules/log"
|
|
)
|
|
|
|
type FuncWithError func() error
|
|
|
|
func SafeFuncWithError(fun FuncWithError) (err error) {
|
|
defer func() {
|
|
if r := recover(); r != nil {
|
|
log.Error("PANIC recovered: %v\nStacktrace: %s", r, log.Stack(2))
|
|
rErr, ok := r.(error)
|
|
if ok {
|
|
err = fmt.Errorf("PANIC recover with error: %w", rErr)
|
|
} else {
|
|
err = fmt.Errorf("PANIC recover: %v", r)
|
|
}
|
|
}
|
|
}()
|
|
|
|
return fun()
|
|
}
|