PeterCxy
/
irqbalance
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add a deprecation notice for IRQBALANCE_BANNED_CPUS 

The IRQBALANCE_BANNED_CPUS and IRQBALANCE_BANNED_CPULIST
environment variable is redundancy, it is enough to leave
only one environment variable. IRQBALANCE_BANNED_CPULIST
is more humanized, so we can discard IRQBALANCE_BANNED_CPUS.

Before deleting this environment variable, introduce a
deprecation period first for the consider of compatibility.
This patch add a deprecation notice.

Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
This commit is contained in:
Yunfeng Ye 2020-11-24 10:11:20 +08:00
parent 31c7d128fd
commit c995237885
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
cputree.c
View File

@ -102,7 +102,7 @@ static void get_mask_from_cpulist(char *line, void *mask)
/* /*
* By default do not place IRQs on CPUs the kernel keeps isolated or * By default do not place IRQs on CPUs the kernel keeps isolated or
* nohz_full, as specified through the boot commandline. Users can * nohz_full, as specified through the boot commandline. Users can
* override this with the IRQBALANCE_BANNED_CPUS environment variable. * override this with the IRQBALANCE_BANNED_CPULIST environment variable.
*/ */
static void setup_banned_cpus(void) static void setup_banned_cpus(void)
{ {
@ -118,9 +118,20 @@ static void setup_banned_cpus(void)
strlen(banned_cpumask_from_ui), banned_cpus); strlen(banned_cpumask_from_ui), banned_cpus);
goto out; goto out;
} }
/*
* Notes:
* The IRQBALANCE_BANNED_CPUS will be discarded, please use
* IRQBALANCE_BANNED_CPULIST instead.
*
* Before deleting this environment variable, Introduce a
* deprecation period first for the consider of compatibility.
*/
env = getenv("IRQBALANCE_BANNED_CPUS"); env = getenv("IRQBALANCE_BANNED_CPUS");
if (env && strlen(env)) { if (env && strlen(env)) {
cpumask_parse_user(env, strlen(env), banned_cpus); cpumask_parse_user(env, strlen(env), banned_cpus);
log(TO_ALL, LOG_WARNING,
"IRQBALANCE_BANNED_CPUS is discarded, Use IRQBALANCE_BANNED_CPULIST instead\n");
goto out; goto out;
} }

4
irqbalance.1
View File

@ -163,7 +163,9 @@ processors, each group of eight hex digits is separated by a comma ’,’. i.e.
to the 7th-12th cpus (cpu6-cpu11) or ‘export IRQBALANCE_BANNED_CPUS=ff000000,00000001‘ to the 7th-12th cpus (cpu6-cpu11) or ‘export IRQBALANCE_BANNED_CPUS=ff000000,00000001‘
would prevent irqbalance from assigning irqs to the 1st (cpu0) and 57th-64th cpus would prevent irqbalance from assigning irqs to the 1st (cpu0) and 57th-64th cpus
(cpu56-cpu63). (cpu56-cpu63).
Notes: This environment variable will be discarded, please use IRQBALANCE_BANNED_CPULIST
instead. Before deleting this environment variable, Introduce a deprecation period first
for the consider of compatibility.
.TP .TP
.B IRQBALANCE_BANNED_CPULIST .B IRQBALANCE_BANNED_CPULIST