Peter Cai

PeterCxy pushed to master at PeterCxy/OpenEUICC

2024-12-14 20:38:39 +01:00

bc238c45cd ui: Add switching timeout message to the new DI text provider

PeterCxy pushed to master at PeterCxy/OpenEUICC

2024-12-14 20:21:36 +01:00

14ea84c36e ui: Add placeholder text for when no eUICC is found to TextProvider

PeterCxy pushed to master at PeterCxy/OpenEUICC

2024-12-14 19:48:08 +01:00

aefa79b18b refactor: Channel format should use DI instead of resource overriding

PeterCxy pushed to master at PeterCxy/OpenEUICC

2024-12-13 14:34:40 +01:00

aed2479044 ui: wizard: Prevent de-selecting checkboxes

PeterCxy pushed to master at PeterCxy/OpenEUICC

2024-12-13 14:33:40 +01:00

f294fb5e17 ui: wizard: Reintroduce support for downloading to USB readers

PeterCxy merged pull request PeterCxy/OpenEUICC#110

2024-12-13 05:15:22 +01:00

feat: if profile delete confirm text is mismatched then show toast

PeterCxy pushed to master at PeterCxy/OpenEUICC

2024-12-13 05:15:21 +01:00

55d96c6732 feat: if profile delete confirm text is mismatched then show toast (#110)

PeterCxy commented on pull request PeterCxy/OpenEUICC#111

2024-12-13 04:49:20 +01:00

feat: profile rename more toast hints

delete "the"

PeterCxy commented on pull request PeterCxy/OpenEUICC#111

2024-12-13 04:48:29 +01:00

feat: profile rename more toast hints

could not be encoded as UTF-8

PeterCxy commented on pull request PeterCxy/OpenEUICC#111

2024-12-13 04:47:52 +01:00

feat: profile rename more toast hints

is unchanged

PeterCxy merged pull request PeterCxy/OpenEUICC#108

2024-12-13 04:41:18 +01:00

refactor: certificate issuer detecting

PeterCxy pushed to master at PeterCxy/OpenEUICC

2024-12-13 04:41:17 +01:00

06873545e2 refactor: certificate issuer detecting (#108)

PeterCxy commented on pull request PeterCxy/OpenEUICC#107

2024-12-13 04:39:26 +01:00

feat: copyable eid string

Please do not commonize strings for copy operations. This is in general not great for i18n.

I am also planning to un-commonize some of the strings that were commonized before.

PeterCxy commented on pull request PeterCxy/OpenEUICC#106

2024-12-13 04:36:52 +01:00

feat: share file after save logs

Share should only be triggered when a separate button is pressed. It is confusing if save also triggers share unconditionally.

PeterCxy suggested changes for PeterCxy/OpenEUICC#110

2024-12-13 04:35:03 +01:00

feat: if profile delete confirm text is mismatched then show toast

PeterCxy commented on pull request PeterCxy/OpenEUICC#110

2024-12-13 04:34:59 +01:00

feat: if profile delete confirm text is mismatched then show toast

unmatched -> mismatched

PeterCxy commented on pull request PeterCxy/OpenEUICC#110

2024-12-13 04:34:55 +01:00

feat: if profile delete confirm text is mismatched then show toast

There's no point having these two vals just to get() = requireArguments().... Using by lazy might be more appropriate if that's the aim.

PeterCxy commented on pull request PeterCxy/OpenEUICC#110

2024-12-13 04:34:51 +01:00

feat: if profile delete confirm text is mismatched then show toast

.also { show() } removes the need for !!

PeterCxy commented on pull request PeterCxy/OpenEUICC#111

2024-12-13 04:30:36 +01:00

feat: profile rename more toast hints

Validating against GSMA standard isn't the concern of UI. This should be custom exceptions thrown from LocalProfileAssistantImpl in lpac-jni and exposed through UI toasts instead.

PeterCxy closed pull request PeterCxy/OpenEUICC#109

2024-12-13 04:27:06 +01:00

fix: override unpriv channel name in all languages